Skip to content

All parsers: anchor is_test_file to path components#108

Open
gadievron wants to merge 1 commit into
masterfrom
pr/is-test-file-anchoring
Open

All parsers: anchor is_test_file to path components#108
gadievron wants to merge 1 commit into
masterfrom
pr/is-test-file-anchoring

Conversation

@gadievron

@gadievron gadievron commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

All parsers: anchor is_test_file to path components

Local-only branch pr/is-test-file-anchoring off master 368b559. One of a coordinated 7-PR set fixing parser/reachability bugs found by the OpenAnt finder. File-disjoint from the other 6 PRs (no merge collision; any order).

Addresses 2 finder bug-ids (2 distinct fixes; 0 ride a same-PR canonical).

Bugs fixed

  • [2] is-test-file-substring (multi/path_substring_exclusion) — genuinely-new (no prior logged entry)
  • [22] zig-path_substring_exclusion-repository_scanner-118 (zig/path_substring_exclusion) — genuinely-new (no prior logged entry)

Dedup status (independent + judge, from raw)

2 genuinely-new · 0 duplicate-of-curated (cross-ref above) · 0 covered-by-curated · 0 intra-PR-duplicate. All re-confirmed STILL PRESENT on pristine master 368b559 (git show 368b559:).

Tests

Verified GREEN in isolation off pristine 368b559: 24 passed (test_repository_scanner_is_test_file_cma). New per-bug regression tests. (No test_<lang>_schema_completeness.py / test_callgraph_symmetry.py parser-infra in this PR — a follow-up; master has none either.)

Notes

  • TDD per bug (RED→GREEN); independent + judge verified each fix from raw against master.
  • No behavior change outside the listed parser(s).

🤖 Generated with Claude Code

@gadievron

gadievron commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

Merge-order note (not a defect — flagging for landing order)

This consolidated is_test_file anchoring supersedes the earlier per-parser versions in #79 and #93 (same parsers/*/repository_scanner.py). Taking this PR wholesale is correct except it does not carry two sub-fixes from those PRs — re-add them on top:

This is the most error-prone overlap in the set.

@gadievron
fix(parsers): CM-A is_test_file anchored to path components, not subs…
47291fc 
…tring (BUG-NEW 2,22)

Local-only finder-fixes-54. 3 parametrized tests across 5 langs.
is_test_file used unanchored 'pattern in path_lower' (zig worst: bare test/spec tokens), so
real source whose name CONTAINS a token (latest/contest/attestation/inspector) was silently
dropped from extraction (skip_tests=True is the pipeline default). Anchored to exact path
DIRECTORY components + basename conventions across c/php/python/ruby/zig repository_scanner.
JS/Go already anchored -> untouched (judge-confirmed). Decoys not excluded; real test files
still excluded (recall preserved). Judge: AGREE / SHIP-AS-IS.
Local-only; not pushed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

(cherry picked from commit d8c5f3fb0387c969a7e7c899a8d59e598c46a477)
@gadievron gadievron force-pushed the pr/is-test-file-anchoring branch from f3f5788 to 47291fc Compare June 29, 2026 18:39
@gadievron

gadievron commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/master (post-release #133 / Wave 1). Conflicts resolved by UNION — both this PR's fix and the Wave-1 parser fixes are preserved; no Wave-1 change reverted (independently judge-verified). Force-pushed with --force-with-lease.

Note: Wave 1 (#133) independently landed an equivalent (superset) is_test_file consolidation, so the production change is subsumed — this PR is now its regression test only (24 anti-substring cases green).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sounil sounil Awaiting requested review from sounil sounil is a code owner
@shahar-davidson shahar-davidson Awaiting requested review from shahar-davidson shahar-davidson is a code owner
@yotamleo yotamleo Awaiting requested review from yotamleo yotamleo is a code owner
@dgeyshis dgeyshis Awaiting requested review from dgeyshis dgeyshis is a code owner
@ar7casper ar7casper Awaiting requested review from ar7casper ar7casper is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gadievron